-
Notifications
You must be signed in to change notification settings - Fork 2.2k
All tasks wait before starting #3676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
20babe4 to
26af26d
Compare
4b4c106 to
468aed5
Compare
26af26d to
932702b
Compare
932702b to
e613fdb
Compare
468aed5 to
c9ff267
Compare
e613fdb to
d9ef4ef
Compare
c9ff267 to
dfa3e44
Compare
dfa3e44 to
28e5a78
Compare
d9ef4ef to
538e084
Compare
28e5a78 to
deb4e5d
Compare
538e084 to
a8c7917
Compare
|
Would an alternative approach be to prepare benchmarks on a single thread while running benchmark tasks on separate threads? That way the preparation part is not being starved. |
deb4e5d to
f670002
Compare
0cb0a47 to
6da0c79
Compare
|
@deuszx Depending on how many benchmark tasks are running, since they're blocking tasks, even if the prepare benchmarks is a single thread, that thread might still struggle to get scheduled to run in the same way :/ |
344a842 to
4029c25
Compare
6da0c79 to
a46ed82
Compare
a46ed82 to
da4a06d
Compare
4029c25 to
87a1499
Compare
87a1499 to
05a1ca6
Compare

Motivation
When you have a lot of chains, some of them might start sending requests before all tasks have started. This can cause the last tasks to struggle getting scheduled.
Proposal
Synchronizing before starting should fix that
Test Plan
Will test on the benchmarks
Release Plan